Discovery Gaming Community
Givecash and PoBs - Printable Version

+- Discovery Gaming Community (https://discoverygc.com/forums)
+-- Forum: Discovery Development (https://discoverygc.com/forums/forumdisplay.php?fid=7)
+--- Forum: Discovery Mod General Discussion (https://discoverygc.com/forums/forumdisplay.php?fid=37)
+--- Thread: Givecash and PoBs (/showthread.php?tid=159665)

Givecash and PoBs - Spectre - 03-31-2018

So real quick, it seems the /givecash command is bugging out, as every time I try to send money from my bank to my PoB supply ship, it gives me this error..

[Image: 3OM0qCQ.png]

I've tried with the ship I was going to send the money to, and got the same error. No money gets sent.

What's more is that when I tried to send the money to the supply ship while it was docked on my PoB, not only would it not send the money, but the PoB would temporarily be disabled upon login of that character, and would spit me out 100k below the system plane.

I'd like to know exactly what is causing this, if it's client-side possibly, and if it can be fixed soon since I'm prepping for a siege and I'd really rather not waste the effort made to get it to that point.


[EDIT]: Restart Fixed it. God bless you, Inf.
For the record I didn't restart the server, I crashed it, but I'll take the credit regardless.

RE: Givecash and PoBs - Remnant - 03-31-2018

Inside the current playerbase plugin, the ReqChangeCash and ReqSetCash hooks are set to ignore other plugins if you are docked at a PoB.

Code:
/// Ignore cash commands from the client when we're in a player base.
void __stdcall ReqChangeCash(int cash, unsigned int client)
{
    returncode = DEFAULT_RETURNCODE;
    if (clients[client].player_base)
        returncode = SKIPPLUGINS_NOFUNCTIONCALL;
}

/// Ignore cash commands from the client when we're in a player base.
void __stdcall ReqSetCash(int cash, unsigned int client)
{
    returncode = DEFAULT_RETURNCODE;
    if (clients[client].player_base)
        returncode = SKIPPLUGINS_NOFUNCTIONCALL;
}

PlayerCntl must be running it's logic first, but while /givecash does it's thing, the playerbase blocks the request ungracefully. /givecash doesn't appear to handle this problem very well. I'm not surprised that it's causing issues.

It's not clientside. It's a problem with the base plugin.

I'm glad a restart fixed it, although this probably should get addressed eventually, just to make sure the plugins play nice with each other.