Freelancer Companion update for DiscoveryGC (Current: v4.32)

[Derpcopter]

Was able to capture the last i see:

[evanz]

mine started crashing after i set some limitation settings, is there a way or a feature or a seperate thing you can code, to reset limitations or config to default

[Its Raisu]

mine started crashing after i set some limitation settings, is there a way or a feature or a seperate thing you can code, to reset limitations or config to default

If you're comfortable with navigating the Registry Editor, could you show me what "HKEY_CURRENT_USER\SOFTWARE\Wizou\FLCompanion\Settings" looks like?

[evanz]

mine started crashing after i set some limitation settings, is there a way or a feature or a seperate thing you can code, to reset limitations or config to default

If you're comfortable with navigating the Registry Editor, could you show me what "HKEY_CURRENT_USER\SOFTWARE\Wizou\FLCompanion\Settings" looks like?

https://i.imgur.com/3hroNVb.png

[Its Raisu]

https://i.imgur.com/3hroNVb.png

Short story on the crash I was able to identify:
It was possible for the Max Investment setting to set the number of units to 0 for some of the calculations that later occurred when generating the trade solutions. This caused a divide by zero error which is fixed in v4.32.

More detailed bit, for anyone interested in code bs

Line 1 calculates the number of units based on cargo size setting.
Line 2 and 3 ends processing for that trade if the number of units is 0.
Line 4 and 5 recalculates the number of units based on maxinvestment setting if it isn't enough to cover a full cargo load.

Line 4 and 5 can result in the number of units being set to 0. Which, as you see in Line 2 and 3, we should immediately end processing for.
Later in the function, "units" is used in "profit / units" or, in the case of what was causing the crash, "profit / 0"

This was fixed by swapping Line 2 and 3 and Line 4 and 5 so that each instance of "units" being 0 is handled properly.

Before:

Code:

    UINT units = m_cargoSize == 1 ? 1 : UINT(m_cargoSize/g_goods[goodIndex].m_volume);
    if (units == 0)
        return;
    if ((m_maxInvestment > 0) && (srcsell*units > m_maxInvestment))
        units = UINT(m_maxInvestment/srcsell);

<snip>

FLOAT calcCSU = (profit / units / g_goods[goodIndex].m_volume) * 100000 / distance;

After:

Code:

    UINT units = m_cargoSize == 1 ? 1 : UINT(m_cargoSize/g_goods[goodIndex].m_volume);
    if ((m_maxInvestment > 0) && (srcsell*units > m_maxInvestment))
        units = UINT(m_maxInvestment/srcsell);
    if (units == 0)
        return;

<snip>

FLOAT calcCSU = (profit / units / g_goods[goodIndex].m_volume) * 100000 / distance;

This was a mix of how FLCompanion was originally coded, and the addition of always utilizing the CSU calculation rather than only calculating it when Cargo Size was set to 1.

[Helo]

Unfortunately current version also crashes. Same way as before I only get message log for split second before it crashes.

---

Remember the ICMG

[Longhorn]

Mine also crashing:

Faulting application name: FLCompanion.exe, version: 4.32.0.0, time stamp: 0x6564233e
Faulting module name: FLCompanion.exe, version: 4.32.0.0, time stamp: 0x6564233e
Exception code: 0xc0000409
Fault offset: 0x00021781
Faulting process id: 0x0x233C
Faulting application start time: 0x0x1DA2B76C69EE4DF
Faulting application path: C:\Users\x\Downloads\FLCompanion (v4.32)\FLCompanion.exe
Faulting module path: C:\Users\x\Downloads\FLCompanion (v4.32)\FLCompanion.exe
Report Id: 346dc345-1f04-46b0-aae6-bcaf55b9f0f1
Faulting package full name:
Faulting package-relative application ID:

---

New to freelancer

[Helo]

Well still the same old crash with message log

---

Remember the ICMG